Skip to content

ARTESCA-14679 // add version in remoteEntry file#4528

Merged
bert-e merged 1 commit intodevelopment/129.0from
improvement/ARTESCA-14679
Mar 3, 2025
Merged

ARTESCA-14679 // add version in remoteEntry file#4528
bert-e merged 1 commit intodevelopment/129.0from
improvement/ARTESCA-14679

Conversation

@hervedombya
Copy link
Copy Markdown
Contributor

Component:

Context:

Summary:

Acceptance criteria:


Closes: #ISSUE_NUMBER

@hervedombya hervedombya requested a review from a team as a code owner February 28, 2025 15:55
@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Feb 28, 2025

Hello hervedombya,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Feb 28, 2025

Request integration branches

Waiting for integration branch creation to be requested by the user.

To request integration branches, please comment on this pull request with the following command:

/create_integration_branches

Alternatively, the /approve and /create_pull_requests commands will automatically
create the integration branches.

Add step to retrieve METALK8S_VERSION in build workflow

Remove METALK8S_VERSION retrieval step and add version fallback in doit.sh

Refactor version retrieval logic in doit.sh and entrypoint.sh to improve clarity and maintainability

Update VERSION_FILE path in entrypoint.sh for consistency

Update Dockerfile to include VERSION file and remove version retrieval logic from entrypoint.sh

Update Dockerfile and rspack.config.ts to remove VERSION file dependency and use git revision for filename

Update Dockerfile to copy VERSION file and modify rspack.config.ts to read version from the file

Update Dockerfile to create VERSION file with version details during build
@hervedombya hervedombya force-pushed the improvement/ARTESCA-14679 branch from 125ac7d to a7fa3d5 Compare March 2, 2025 18:26
@hervedombya
Copy link
Copy Markdown
Contributor Author

/approve

@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Mar 3, 2025

Integration data created

I have created the integration data for the additional destination branches.

The following branches will NOT be impacted:

  • development/123.0
  • development/124.0
  • development/124.1
  • development/125.0
  • development/126.0
  • development/127.0
  • development/128.0
  • development/2.0
  • development/2.1
  • development/2.10
  • development/2.11
  • development/2.2
  • development/2.3
  • development/2.4
  • development/2.5
  • development/2.6
  • development/2.7
  • development/2.8
  • development/2.9

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

The following options are set: approve

Copy link
Copy Markdown
Contributor

@ChengYanJin ChengYanJin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hervedombya
Copy link
Copy Markdown
Contributor Author

/approve

@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Mar 3, 2025

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/129.0

  • ✔️ development/130.0

The following branches have NOT changed:

  • development/123.0
  • development/124.0
  • development/124.1
  • development/125.0
  • development/126.0
  • development/127.0
  • development/128.0
  • development/2.0
  • development/2.1
  • development/2.10
  • development/2.11
  • development/2.2
  • development/2.3
  • development/2.4
  • development/2.5
  • development/2.6
  • development/2.7
  • development/2.8
  • development/2.9

Please check the status of the associated issue ARTESCA-14679.

Goodbye hervedombya.

The following options are set: approve

@bert-e bert-e merged commit a7fa3d5 into development/129.0 Mar 3, 2025
27 checks passed
@bert-e bert-e deleted the improvement/ARTESCA-14679 branch March 3, 2025 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants